Added nodes.read endpoint so you can query by hostname to get the system_id indirectly #239
Conversation
Codecov Report
@@ Coverage Diff @@
## master #239 +/- ##
==========================================
- Coverage 67.98% 67.98% -0.01%
==========================================
Files 70 70
Lines 5726 5728 +2
Branches 988 988
==========================================
+ Hits 3893 3894 +1
- Misses 1610 1611 +1
Partials 223 223
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #239 +/- ##
==========================================
- Coverage 67.98% 67.98% -0.01%
==========================================
Files 70 70
Lines 5726 5728 +2
Branches 988 988
==========================================
+ Hits 3893 3894 +1
- Misses 1610 1611 +1
Partials 223 223
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Thanks for the contribution! Can you please add a test for this in this file https://github.com/maas/python-libmaas/blob/master/maas/client/tests/test_facade.py ?
The nodes endpoint is completely missing in facade.py Added the nodes.read (thus client.nodes.read(hostnames=[]) This allows for querying maas by hostname QUICKLY which gets you the system_id which you can then query for full machine detail. This a workaround due to clien.machines.read() only accepting a system_id argument unlike the maas Client API distributed with maas since at least 2.6.2 which supports querying on a wide variety of criteria see #238